Skip to content

Comments

Remove rust-analyzer from rust package#271

Open
baszalmstra wants to merge 3 commits intoconda-forge:mainfrom
baszalmstra:claude/split-rustdocs-component-c481U
Open

Remove rust-analyzer from rust package#271
baszalmstra wants to merge 3 commits intoconda-forge:mainfrom
baszalmstra:claude/split-rustdocs-component-c481U

Conversation

@baszalmstra
Copy link
Member

@baszalmstra baszalmstra commented Feb 10, 2026

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

rust-analyzer takes up ~37MB (~4% of the package size) and follows its own update schedule, receiving updates more frequently than the main Rust release cycle. Since it's not required for standard Rust compilation, it should not be bundled with the core toolchain.

This change:

  • Removes rust-analyzer binary and manifest from the rust package
  • Adds tests to verify rust-analyzer is not present

Closes #270

@claude
Remove rust-analyzer from rust package
a714f8e 
rust-analyzer takes up ~37MB (~4% of the package size) and follows its
own update schedule, receiving updates more frequently than the main
Rust release cycle. Since it's not required for standard Rust
compilation, it should not be bundled with the core toolchain.

This change:
- Removes rust-analyzer binary and manifest from the rust package
- Adds tests to verify rust-analyzer is not present

Closes conda-forge#270

https://claude.ai/code/session_01C7479gGk3F48xKFvTiFPzG
@claude
Bump build number
040adc6 
https://claude.ai/code/session_01C7479gGk3F48xKFvTiFPzG
@baszalmstra
Copy link
Member Author

baszalmstra commented Feb 10, 2026

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Feb 10, 2026 •
edited
Loading

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ Use of posix package on windows is deprecated. Use m2-base.
  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/21873676518. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Feb 10, 2026

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/21860084420. Examine the logs at this URL for more detail.

@baszalmstra baszalmstra marked this pull request as ready for review February 10, 2026 10:22
@baszalmstra baszalmstra mentioned this pull request Feb 10, 2026
Open
@pkgw
Copy link
Contributor

pkgw commented Feb 10, 2026

This isn't quite working as intended on Windows — the PR contains no change to install-rust.bat, but it appears that the rust-analyzer pieces are named rust-analyzer-preview and installed under different names such that the Windows check added in meta.yaml succeeds nonetheless. We should update install-rust.bat to properly remove the analyzer bits and fix the check in meta.yaml.

@baszalmstra
Copy link
Member Author

baszalmstra commented Feb 10, 2026

There is some black magic trickery that simply invokes install_rust.sh on windows and sets %PREFIX% to be %PREFIX%/Library. If you check the build output you will see the files are not include anymore.

Doing so I noticed that the pdb is still there. I removed that now as well.

@isuruf
Copy link
Member

isuruf commented Feb 10, 2026

Please move rust-analyzer to a separate output instead of just outright deleting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhi18av abhi18av Awaiting requested review from abhi18av abhi18av is a code owner

@dlaehnemann dlaehnemann Awaiting requested review from dlaehnemann dlaehnemann is a code owner

@isuruf isuruf Awaiting requested review from isuruf isuruf is a code owner

@johanneskoester johanneskoester Awaiting requested review from johanneskoester johanneskoester is a code owner

@mbargull mbargull Awaiting requested review from mbargull mbargull is a code owner

@pkgw pkgw Awaiting requested review from pkgw pkgw is a code owner

@timkpaine timkpaine Awaiting requested review from timkpaine timkpaine is a code owner

@xhochy xhochy Awaiting requested review from xhochy xhochy is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove/split rust-analyzer from rust

5 participants

@baszalmstra @conda-forge-admin @pkgw @isuruf @claude